Repository navigation
Conversation
correlation (Δφ, Δη) analysis in pp collisions at 13 TeV, structured in parallel with the AliRoot AliMESppColTask analysis, to PWGCF/TwoParticleCorrelations. Adds an analysis task (o2-analysis-cf-two-particle-correlations-mult-spher) that fills same-event and mixed-event Δφ-Δη correlation histograms (THnSparse for the full multi-dimensional binning, plus direct TH2D SE/ME pairs for both per-trigger and per-pair normalisation), differential in multiplicity class and transverse sphericity class, at both MC generator level and reconstructed level. Some selection variants are kept togglable via Configurables for methodology cross-checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YbYBgosEJaDJTkCuqAtNHk
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Applies clang-format (project style) and converts C-style casts to static_cast, as flagged by the cpplint check in CI. No behavior change: rebuilt and re-ran the single-file smoke test, same histogram counts as before. Also adds the <memory> include cpplint pointed out for shared_ptr<>. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YbYBgosEJaDJTkCuqAtNHk
Framework/*.h headers must use angle brackets (<...>), not quotes, per the O2Physics include-style convention (Scripts/format_includes.awk) enforced by the PR formatting / clang-format CI check. Re-ran clang-format after the change; rebuilt and re-ran the single-file smoke test, same result as before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YbYBgosEJaDJTkCuqAtNHk
matarzil
marked this pull request as ready for review
October 1, 2026 17:48
matarzil
requested review from
alibuild,
dsarkaralice,
jaelpark,
lauraser,
victor-gonzalez and
wenyaCern
as code owners
October 1, 2026 17:48
Author
|
Hi @jaelpark @wenyaCern @lauraser @dsarkaralice @victor-gonzalez , this PR adds a new two-particle angular correlation analysis task (Δφ-Δη, differential in multiplicity and transverse sphericity) to PWGCF/TwoParticleCorrelations, and adds the corresponding workflow block to PWGCF/TwoParticleCorrelations/Tasks/CMakeLists.txt, which needs a PWGCF |
resolution. The web-based merge-conflict editor used to resolve the upstream/master merge dropped the "COMPONENT_NAME Analysis)" line closing the two-particle-correlations-mult-spher workflow block, running it into the next block (hparticle-correlation) and breaking CMake configuration. Verified: CMake reconfigure, incremental rebuild, and single-file smoke test all clean after the fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YbYBgosEJaDJTkCuqAtNHk
lauraser
previously approved these changes
Oct 7, 2026
lauraser
enabled auto-merge (squash)
October 7, 2026 12:46
Collaborator
|
Error while checking build/O2Physics/code-check for 4b4b132 at 2026-10-07 14:47: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 4b4b132 at 2026-10-07 14:51: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 4b4b132 at 2026-10-07 15:01: Full log here. |
…orrectness Removes the dead kSphMin constant and yLead variable, adds [[maybe_unused]] to the struct members and bookChannel lambda parameters that are only referenced inside the disabled histogram-budget blocks, and adds const to those same lambda parameters per cppcheck's constParameterReference suggestion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YbYBgosEJaDJTkCuqAtNHk
auto-merge was automatically disabled
October 7, 2026 13:53
Head branch was pushed to by a user without write access
lauraser
previously approved these changes
Oct 7, 2026
lauraser
enabled auto-merge (squash)
October 7, 2026 14:36
vkucera
requested changes
Oct 7, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Dear @matarzil , since you are adding a new file, I strongly recommend to fix all reported errors and warnings, otherwise they will keep popping up in all future PRs.
Formatting the includes is mandatory because it's part of the required formatting check.
vkucera
disabled auto-merge
October 7, 2026 14:51
Collaborator
- Remove dead code (#if 0 blocks, unused histograms/axes/parameters) - Use RecoDecay::constrainAngle instead of custom computeDeltaPhi - Use O2DatabasePDG service instead of TDatabasePDG - Replace hard-coded bin logic with edge arrays and o2::analysis::findBin - Generate multiplicity labels from the bin edges - Fix include grouping and remove comments between includes
Author
|
Dear @vkucera, thank you for the feedback. |
vkucera
reviewed
Oct 9, 2026
Collaborator
Thanks for the improvements. You still have 52 warnings from O2 linter. Do you plan to fix them in this PR? For the future, please let the person who made the comment mark their comments as resolved. (Please see the contribution guidelines for more details on the PRs.) |
Author
|
Thanks for the heads-up on both points, @vkucera. I think I fixed them this time. |
vkucera
reviewed
Oct 9, 2026
Comment on lines
+282
to
+291
| switch (std::abs(pdg)) { | ||
| case 211: | ||
| return PidPion; | ||
| case 321: | ||
| return PidKaon; | ||
| case 2212: | ||
| return PidProton; | ||
| default: | ||
| return PidUnidentified; | ||
| } |
Collaborator
There was a problem hiding this comment.
You still have magic numbers here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first commit of this task. It adds the two-particle angular correlation (Δφ, Δη) analysis in pp collisions at 13 TeV, structured in parallel with the AliRoot AliMESppColTask analysis, to PWGCF/TwoParticleCorrelations.
Adds an analysis task (o2-analysis-cf-two-particle-correlations-mult-spher) that fills same-event and mixed-event Δφ-Δη correlation histograms (THnSparse for the full multi-dimensional binning, plus direct TH2D SE/ME pairs for both per-trigger and per-pair normalisation), differential in multiplicity class and transverse sphericity class, at both MC generator level and reconstructed level. Some selection variants are kept togglable via Configurables for methodology cross-checks.